Fix cloning of NamedListLike objects #7769
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an error where cloning with only the `object` keyword argument caused an exception.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7769 +/- ##
==========================================
- Coverage 87.11% 86.16% -0.95%
==========================================
Files 346 346
Lines 52793 52793
==========================================
- Hits 45988 45488 -500
- Misses 6805 7305 +500 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hoxbro
changed the title
|
Looks ok to me. Can you add a test for this? |
I've extended existing ones, hope that's ok |
philippjfr
approved these changes
Mar 13, 2025
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an error where cloning with only the
objectkeyword argument caused an exception.